Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39868 )
Change subject: mb/google/deltaur: Return SKU ID info
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39868/8/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/deltaur/sku.c:
https://review.coreboot.org/c/coreboot/+/39868/8/src/mainboard/google/deltau...
PS8, Line 31: !
!! would be a little more correct here.
the has_360_sensor_board returns 1 for 360 config and 0 for clamshell. Therefor i guess it should be !has_360_sensor_board. That way we have the following the result of the following
expression would be
(!has_360_sensor_board()) | (wilco_ec_signed_fw() << 1)
0 -> 360
1 -> 180
2 -> 360 signed
3 -> 180 signed
This is as per https://partnerissuetracker.corp.google.com/u/1/issues/152333562.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20a497739e5062400b093648c3a634203dec6105
Gerrit-Change-Number: 39868
Gerrit-PatchSet: 9
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Kevin Chowski
chowski@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Apr 2020 19:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment