Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36093 )
Change subject: mb/lenovo/x200: Add ThinkPad X301 as a variant
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36093/3/src/mainboard/lenovo/x200/M...
File src/mainboard/lenovo/x200/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36093/3/src/mainboard/lenovo/x200/M...
PS3, Line 16: variants/$(VARIANT_DIR)/dock.c
I agree with you, but now I may have to use dirty hack to fight another widely used dirty hack.
Simply add a flag like "HAS_DOCK_CONNECTOR" may affect all target related to H8_DOCK_EARLY_INIT.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6a6059ccf15dd2e43ed4fc490c1d3c36aa1e817
Gerrit-Change-Number: 36093
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Comment-Date: Fri, 18 Oct 2019 16:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Gerrit-MessageType: comment