Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40377 )
Change subject: coreboot-id: Add coreboot id based on FMAP entries ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/mc_apl_vboot.fmd:
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... PS2, Line 9: COREBOOT_ID 0x40 : RO_FRID_PAD 0x780
Actually, no. The reason I dropped it from Chrome OS boards is because I am confident that we don't use it and we have RO_FRID which already stores similar information. I can add it back if you want all boards to be consistent.
Okay, but... don't you still think that adding it to 100 different FMAP files (and having to subsequently fit it into every future FMAP we'll write) would be a hassle that would be nice to avoid?
But, I don't think it really adds more value to Chrome OS boards where we already have RO_FRID.
Note that they look more similar here than they actually are, since for a developer build the default sets the vboot version to the coreboot version (including Git SHA). For actual production Chromebook firmware this gets overridden by our official firmware version (from the branch builder) and the coreboot Git SHA is lost.
Then again, like I said I doubt it adds much value to anyone at all right now so I would also be okay with removing it entirely unless non-Chrome people say they like to have it. But if we do keep it as the official coreboot version info independent from vboot, I think that should apply to all configurations.