Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support
......................................................................
Patch Set 36:
Patch Set 36:
Patch Set 33:
(13 comments)
To do:
I am looking for guidance/direction about the config to get Jenkins to build the STM.
Next patch set will be out Fri/Sat and will include the addition of get_pmbase for all Intel platforms. Unless the reviewers want me to separate them into separate CL's
Given the requests people made to have it in one CL, back when it was multiple CLs, let's just keep it in one CL.
I request it to be split into smaller chunks that separate code changes by topic, can be easily reviewed, that build and doesn't break existing platforms.
I'm not sure if CamelCase coding style is allowed, as no other file has it.
To let Jenkins build test it: add a defconfig to the configs/ folder
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4adcd92c341162630ce1ec357ffcf8a135785ec
Gerrit-Change-Number: 33234
Gerrit-PatchSet: 36
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 27 Dec 2019 19:47:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment