Attention is currently required from: Felix Singer, Angel Pons.
Marvin Drees has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48648 )
Change subject: [WIP] mb/asus/sklkbl_h: Add base for Asus Skylake Boards
......................................................................
Patch Set 16:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48648/comment/edd7a8c9_209a868a
PS16, Line 24: - Figure out why system_reset() gets called during
: FSP MemoryInit on cold boot once
If by "cold boot" you mean after the power supply was unplugged, it's completely normal. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab30596f2a12931679687c9f56427712b65f9363
Gerrit-Change-Number: 48648
Gerrit-PatchSet: 16
Gerrit-Owner: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 18 Aug 2021 12:52:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment