Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31049 )
Change subject: src: Don't use a #defines like Kconfig symbols ......................................................................
Patch Set 5: Code-Review+2
(3 comments)
https://review.coreboot.org/#/c/31049/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31049/3//COMMIT_MSG@9 PS3, Line 9: This is sppoted using ./util/lint/kconfig_lint
still, s *p* o *tt* ed
Done
https://review.coreboot.org/#/c/31049/3/src/northbridge/amd/amdfam10/util.c File src/northbridge/amd/amdfam10/util.c:
https://review.coreboot.org/#/c/31049/3/src/northbridge/amd/amdfam10/util.c@... PS3, Line 42: #define CONF_ROUTE_END 0xec
missaligned now
Done
https://review.coreboot.org/#/c/31049/3/src/soc/rockchip/rk3288/sdram.c File src/soc/rockchip/rk3288/sdram.c:
https://review.coreboot.org/#/c/31049/3/src/soc/rockchip/rk3288/sdram.c@384 PS3, Line 384: #define CONFIG (1)
mind changing this as well? otherwise the relation to CONF_REQ might be missed
Done