Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46569 )
Change subject: mb/google/dedede: Update the flash ROM layout for RW regions ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46569/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46569/1//COMMIT_MSG@8 PS1, Line 8:
Please describe the problems the layout update is addressing.
Done
https://review.coreboot.org/c/coreboot/+/46569/1//COMMIT_MSG@8 PS1, Line 8:
It would be good to capture these as documentation in the form of guidelines on how to best allocate […]
Ack. I will submit a follow-up CL with a document containing the guidelines. I will limit the scope of the document to ChromeOS. I am envisioning a master document with additional pointers to SoC specific documents.
https://review.coreboot.org/c/coreboot/+/46569/1//COMMIT_MSG@26 PS1, Line 26: fine after the update.
I would like to point out that after this change, each FW_MAIN_A/B have ~1 MiB of space left.
Ack