[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Do not read SPD again if index hasn't changed

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33137 )

Change subject: soc/intel/cannonlake: Do not read SPD again if index hasn't changed
......................................................................

Patch Set 1:
> Patch Set 1:
>
> I don't understand the purpose of this; is reading CBFS data expensive in terms of time?

It will definitely have to do more work. cbfs_locate() will parse all the files in CBFS until it finds the required file. Also, this work is completely redundant since it has already been done for the previous slot. I did a very quick timestamp check and it seems to add ~6-10ms.