[coreboot-gerrit] Change in coreboot[master]: sc7180: Add clock driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35496 )

Change subject: sc7180: Add clock driver
......................................................................

Patch Set 20:

(3 comments)

https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/bo... 
File src/soc/qualcomm/sc7180/bootblock.c:

https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/bo... 
PS15, Line 19: #include <soc/clock.h>
> Still twice

Ack

https://review.coreboot.org/c/coreboot/+/35496/9/src/soc/qualcomm/sc7180/clo... 
File src/soc/qualcomm/sc7180/clock.c:

https://review.coreboot.org/c/coreboot/+/35496/9/src/soc/qualcomm/sc7180/clo... 
PS9, Line 65: 0x00004805
> You're welcome to use either the new (SET32_BITFIELDS) or the old way (just shifting and ORing the b […]

Ack

https://review.coreboot.org/c/coreboot/+/35496/9/src/soc/qualcomm/sc7180/clo... 
PS9, Line 176: 	clrbits_le32(&aoss->aoss_cc_apcs_misc, BIT(AOP_RESET_SHFT));
> Yes, I am checking internally and would update.

Ack