Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: mediatek/mt8183: Init SPM driver ......................................................................
Patch Set 49:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34545/45/src/mainboard/google/kukui... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34545/45/src/mainboard/google/kukui... PS45, Line 206: "SPM initialization failed, suspend/resume may fail.\n");
"Failed to init SPM, suspend/resume may fail.\n" […]
Done
https://review.coreboot.org/c/coreboot/+/34545/46/src/soc/mediatek/mt8183/sp... File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/34545/46/src/soc/mediatek/mt8183/sp... PS46, Line 320: = NULL
no need to init since we're not using it before it's assigned.
Done
https://review.coreboot.org/c/coreboot/+/34545/46/src/soc/mediatek/mt8183/sp... PS46, Line 334: : if (dyna_load_pcm[index].ready) : pcmdesc = &(dyna_load_pcm[index].desc); : else { : printk(BIOS_ERR, "SPM: firmware is not ready!\n"); : printk(BIOS_ERR, "SPM: check dram type and firmware version!\n"); : return -1; : }
if (!dyna_load_pcm[index].ready) { […]
Done