[coreboot-gerrit] Change in coreboot[master]: sb/intel: Factor out early_smbus.c for ICH7 and newer

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40271 )

Change subject: sb/intel: Factor out early_smbus.c for ICH7 and newer
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40271/1/src/southbridge/intel/commo... 
File src/southbridge/intel/common/early_smbus.c:

https://review.coreboot.org/c/coreboot/+/40271/1/src/southbridge/intel/commo... 
PS1, Line 20: device
> it says device here (not vendor)

I think this is wrong on other platforms then

https://review.coreboot.org/c/coreboot/+/40271/1/src/southbridge/intel/commo... 
PS1, Line 21: 	if (pci_read_config16(dev, PCI_VENDOR_ID) != PCI_VENDOR_ID_INTEL)
> please do functional changes in advance. the huge patch would ideally be […]

Understood