Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48597 )
Change subject: trace: Use dynamic address bytes everywhere we should.
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/em100/+/48597/1/trace.c
File trace.c:
https://review.coreboot.org/c/em100/+/48597/1/trace.c@235
PS1, Line 235: /* Special commands */
: switch (spi_command) {
: case 0xb7:
: address_mode = 4;
: break;
: case 0xe9:
: address_mode = 3;
: break;
: }
Huh, this is indented with spaces
Ah, this was added in CB:48553
--
To view, visit
https://review.coreboot.org/c/em100/+/48597
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I0614bd39d0b47331ffb96195da3624240ef29ffa
Gerrit-Change-Number: 48597
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Dec 2020 10:07:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment