Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38998 )
Change subject: mb/intel/tglrvp: add Tiger Lake memory initialization support ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38998/13/src/mainboard/intel/tglrvp... File src/mainboard/intel/tglrvp/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38998/13/src/mainboard/intel/tglrvp... PS13, Line 22: ifeq ($(SPD_SOURCES),) : SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this) : else Given that the SPD_SOURCES are set just couple of lines above, this check looks redundant.