Attention is currently required from: Angel Pons, Felix Singer, Iru Cai, Paul Menzel.
Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46630?usp=email )
Change subject: mb/hp: Add EliteBook 820 G2 ......................................................................
Patch Set 11:
(5 comments)
File Documentation/mainboard/hp/elitebook_820_g2.md:
https://review.coreboot.org/c/coreboot/+/46630/comment/4de187e0_220f04c0 : PS8, Line 115: (needs a modified refcode)
Looks also good to me. […]
Done
File src/mainboard/hp/elitebook_820_g2/Kconfig:
https://review.coreboot.org/c/coreboot/+/46630/comment/22b4cfd3_61077079 : PS10, Line 23: default "8086,1616"
Did youn test the VGA BIOS? If not, please remove. […]
Done
File src/mainboard/hp/elitebook_820_g2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46630/comment/bbbbe71b_8b871fa6 : PS10, Line 2: register "gfx" = "GMA_STATIC_DISPLAYS(0)" : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "0" : register "panel_cfg" = "{ : .up_delay_ms = 200, : .down_delay_ms = 50, : .cycle_delay_ms = 500, : .backlight_on_delay_ms = 1, : .backlight_off_delay_ms = 1, : .backlight_pwm_hz = 200, : }"
The other Broadwell boards have gfx stuff at the top of the devicetree, though.
Done
https://review.coreboot.org/c/coreboot/+/46630/comment/b7b50507_9080713e : PS10, Line 56: # LPC bridge
nit: align with other comments
Done
File src/mainboard/hp/elitebook_820_g2/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/46630/comment/99a39047_ce09a508 : PS10, Line 28: #include <soc/intel/broadwell/pch/acpi/pch.asl>
Don't you need some include for backlight stuff? […]
Done