[coreboot-gerrit] Change in coreboot[master]: volteer: Create halvor variant

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
PS8, Line 4: SPD_SOURCES =
Paul - I don't think this should be required anymore.

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/gpio.c:

PS8: 
Just a note: I know this is using a script to copy minimal files required for building this target. But, you will have to revisit this file to see if you really need variant_base_gpio_table() or you can make use to the gpio table provided by baseboard with some overrides here.

Similar comment for variant_cros_gpios() and variant_early_gpio_table(). It might be possible to reuse some of these from baseboard.