Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37814 )
Change subject: src/soc/intel/common/block/acpi: Change Processor ACPI Name ......................................................................
src/soc/intel/common/block/acpi: Change Processor ACPI Name
The ACPI Spec 6.2 states, that Processor declarations should be made within the ACPI namespace _SB and not _PR anymore. _PR is deprecated and has been removed here.
Change-Id: Ib101ed718f90f9056d2ecbc31b13b749ed1fc438 Signed-off-by: Christian Walter christian.walter@9elements.com --- M src/arch/x86/Kconfig M src/soc/intel/common/block/acpi/acpi.c 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/37814/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index e27aec2..e863075 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -283,7 +283,7 @@
config ACPI_CPU_STRING string - default "\_PR.CP%02d" + default "CP%02d" depends on HAVE_ACPI_TABLES help Sets the ACPI name string in the processor scope as written by diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index 3a34c79..8488e7e 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -427,6 +427,8 @@ printk(BIOS_DEBUG, "Found %d CPU(s) with %d core(s) each.\n", numcpus, cores_per_package);
+ // Write Scope + acpigen_write_scope("\_SB"); for (cpu_id = 0; cpu_id < numcpus; cpu_id++) { for (core_id = 0; core_id < cores_per_package; core_id++) { if (core_id > 0) { @@ -453,6 +455,8 @@
/* Add a method to notify processor nodes */ acpigen_write_processor_cnot(cores_per_package); + + acpigen_pop_len(); }
#if CONFIG(SOC_INTEL_COMMON_ACPI_WAKE_SOURCE)