Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38639 )
Change subject: soc/intel/common/systemagent: add Kconfig guard
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38639/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38639/1//COMMIT_MSG@9
PS1, Line 9: Looks like having this in the tree force-sets MMCONF_BASE_ADDR to
: some value which can't be overriden anywhe
That's surprising. […]
there as discussion in https://review.coreboot.org/c/coreboot/+/38013 (force abandoned)
it looks like if your platform is not in src/soc you can't really override it.
I do not really understand all the kconfig magic
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia160444e8ac7cac55153f659f4d98f4f77f0d467
Gerrit-Change-Number: 38639
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 30 Jan 2020 01:00:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment