Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34774 )
Change subject: lib: ramdetect: Register exception handlers for ARMv8 ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34774/3/src/arch/arm64/ramdetect.c File src/arch/arm64/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/34774/3/src/arch/arm64/ramdetect.c@... PS3, Line 14: ABORT_CHECKER_NOT_REGISTERED, : ABORT_CHECKER_DEACTIVATED Remove these
https://review.coreboot.org/c/coreboot/+/34774/3/src/arch/arm64/ramdetect.c@... PS3, Line 36: exception_handler I think this needs to be static. Move it out of the function.
https://review.coreboot.org/c/coreboot/+/34774/3/src/arch/arm64/ramdetect.c@... PS3, Line 45: delete register_checker() and add the following: + abort_state == ABORT_CHECKER_NOT_TRIGGERED; + exception_handler_register(EXC_VID_CUR_SP_EL0_SYNC, &sync_el0);
https://review.coreboot.org/c/coreboot/+/34774/3/src/arch/arm64/ramdetect.c@... PS3, Line 47: if (abort_state == ABORT_CHECKER_NOT_TRIGGERED) : return 1; : abort_state = ABORT_CHECKER_NOT_TRIGGERED Replace with: + exception_handler_unregister(EXC_VID_CUR_SP_EL0_SYNC, &sync_el0); + return abort_state == ABORT_CHECKER_NOT_TRIGGERED;
https://review.coreboot.org/c/coreboot/+/34774/3/src/arch/arm64/ramdetect.c@... PS3, Line 53: probe_ramsize You can remove this with the above suggestion.
https://review.coreboot.org/c/coreboot/+/34774/3/src/lib/ramdetect.c File src/lib/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/34774/3/src/lib/ramdetect.c@49 PS3, Line 49: __weak remove the __weak