Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42567 )
Change subject: soc/amd/picasso: Populate EFS SPI values from Kconfig options ......................................................................
Patch Set 9:
(7 comments)
https://review.coreboot.org/c/coreboot/+/42567/8/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/42567/8/src/soc/amd/picasso/Kconfig... PS8, Line 370: choice SPI_READ_MODE
As I mention below, you could just get rid of the choice menu and have one option that lets you dire […]
Did not know I could do that! Definitely will change it to be that way
https://review.coreboot.org/c/coreboot/+/42567/8/src/soc/amd/picasso/Kconfig... PS8, Line 373: default SPI_READ_MODE_NORMAL_66M if BOARD_AMD_MANDOLIN
- this will never have an effect since the first default is the one that gets used. […]
Fixed this thanks to your example.
https://review.coreboot.org/c/coreboot/+/42567/8/src/soc/amd/picasso/Kconfig... PS8, Line 379: (1-1-2)
Maybe address what each of these numbers mean in the help somewhere? […]
Done
https://review.coreboot.org/c/coreboot/+/42567/8/src/soc/amd/picasso/Kconfig... PS8, Line 391: "Normal Read (up to 66M)"
Does this mean 1-1-1?
I need to get answers to this
https://review.coreboot.org/c/coreboot/+/42567/8/src/soc/amd/picasso/Kconfig... PS8, Line 397:
Add EFS_SPI_READ_MODE here so it's not done in the makefile? […]
Also did not realize I could do that. This is way simpler than the makefile.
https://review.coreboot.org/c/coreboot/+/42567/8/src/soc/amd/picasso/Kconfig... PS8, Line 429: Should be set if Micron parts are used for the BIOS SPI chip
I'd like to understand more about this option. […]
Clarified the wording.
https://review.coreboot.org/c/coreboot/+/42567/8/src/soc/amd/picasso/Kconfig... PS8, Line 435: are always be used
"may always be used?"
Done