Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 20: /* coreboot specific header */
I'm not sure. I felt it did not provide much information.
Ack
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 35: : 0x10ec0283
These 4 magic hex numbers should be equivalent to an AZALIA_SUBVENDOR macro. […]
yeah it would be no issue obv if using the subvendor macro
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 22: 13, since this is a quad-byte word like all the rest of the verb data, seems odd to change format here, even for readability
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 49: 0x01471c10, /* group 1, cap 0 */ : 0x01471d01, /* no connector, no jack detect */ : 0x01471e17, /* speaker out, analog */ : 0x01471f90, /* fixed function, internal, Location N/A */ probably easier just to convert to the azalia macros and then have a single comment block, no?