Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38699 )
Change subject: soc/amd/picasso: Add UPD settings to chip.h ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38699/7/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/38699/7/src/soc/amd/picasso/chip.h@... PS7, Line 36: /* Options for these are in src/arch/x86/include/arch/acpi.h */
Are all these really used by SoC and have to be provided by mainboard? Can we add them as required l […]
We do define them all: https://source.corp.google.com/chromeos_public/src/third_party/coreboot-zork...
I could go and break them all up into their own CLs, though they all get used here: https://review.coreboot.org/c/coreboot/+/34423/25/src/soc/amd/picasso/romsta...
I'm just trying to get the CLs that don't have any deps on bootblock landed to shrink the patch train.