Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34581 )
Change subject: mb/google/kohaku: Enable stylus pen device ......................................................................
Patch Set 8:
(7 comments)
Resolving all the comments.
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG@9 PS1, Line 9: Enabling stylus pen device and pen detection event.
Please describe the changes you are marking as part of this CL.
Done
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG@10 PS1, Line 10:
What about pen eject? You added gpio_keys node, but no mention about the change.
Done
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG@13 PS1, Line 13: TEST=Verified pen input operation and pen detection event
Re#3, the wake source does not currently show up, this is a known issue.
Done
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... PS1, Line 49:
It was routed to EMR_GARAGE_INT before, but not used. […]
Done
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... PS1, Line 27: 1
As our device charger checked with wacom, they said we don't need triggering reset for power sequenc […]
Done
https://review.coreboot.org/c/coreboot/+/34581/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/34581/2/src/mainboard/google/hatch/... PS2, Line 27: 1
Yeah, it is being tracked at b/137326841 to understand what the real power-on sequencing requirement […]
Done
https://review.coreboot.org/c/coreboot/+/34581/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34581/5/src/mainboard/google/hatch/... PS5, Line 89: reset_gpio
We cannot use GPP_A10 as reset_gpio (b/137326841#comment86) so need further discussion. […]
Done