Resolving all the comments.
7 comments:
Patch Set #1, Line 9: Enabling stylus pen device and pen detection event.
Please describe the changes you are marking as part of this CL.
Done
What about pen eject? You added gpio_keys node, but no mention about the change.
Done
Patch Set #1, Line 13: TEST=Verified pen input operation and pen detection event
Re#3, the wake source does not currently show up, this is a known issue.
Done
File src/mainboard/google/hatch/variants/kohaku/gpio.c:
It was routed to EMR_GARAGE_INT before, but not used. […]
Done
As our device charger checked with wacom, they said we don't need triggering reset for power sequenc […]
Done
File src/mainboard/google/hatch/variants/kohaku/gpio.c:
Yeah, it is being tracked at b/137326841 to understand what the real power-on sequencing requirement […]
Done
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
Patch Set #5, Line 89: reset_gpio
We cannot use GPP_A10 as reset_gpio (b/137326841#comment86) so need further discussion. […]
Done
To view, visit change 34581. To unsubscribe, or for help writing mail filters, visit settings.