Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40295 )
Change subject: soc/amd/common/psp: Add SmmInfo command ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40295/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40295/1//COMMIT_MSG@17 PS1, Line 17: calls A tad bit too long? limit is 72 chars
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/psp_def.h:
https://review.coreboot.org/c/coreboot/+/40295/1/src/soc/amd/common/block/ps... PS1, Line 86: uint64_t smm_base; /* TSEG base */
please, no spaces at the start of a line
Mr. Jenkins has a point.