Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37174 )
Change subject: binaryPI: Remove FieldAccessors.[ch]
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37174/1/src/vendorcode/amd/pi/00630...
File src/vendorcode/amd/pi/00630F01/AMD.h:
https://review.coreboot.org/c/coreboot/+/37174/1/src/vendorcode/amd/pi/00630...
PS1, Line 162: AMD_SET_VALUE_invalid = 0x00081000,
Why do you leave these?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37174
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59d0c450583b2ff58031c127aae881d1f3799338
Gerrit-Change-Number: 37174
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Sun, 24 Nov 2019 10:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment