Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43959 )
Change subject: soc/mediatek/mt8192: Add gpio driver ......................................................................
Patch Set 4:
(1 comment)
Please "chmod -x " for all files listed below.
File src/soc/mediatek/mt8192/gpio.c has one or more executable bits set in the file permissions. File src/soc/mediatek/mt8192/include/soc/gpio_base.h has one or more executable bits set in the file permissions. File src/soc/mediatek/mt8192/include/soc/infracfg.h has one or more executable bits set in the file permissions. File src/soc/mediatek/mt8192/include/soc/mcucfg.h has one or more executable bits set in the file permissions. File src/soc/mediatek/mt8192/include/soc/pll.h has one or more executable bits set in the file permissions. File src/soc/mediatek/mt8192/pll.c has one or more executable bits set in the file permissions.
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/gpio_base.h:
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/inc... PS1, Line 1: /*
need SPDX header
Ack