28 Apr
2020
28 Apr
'20
7:26 p.m.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38696 )
Change subject: vc/amd/fsp/picasso: Update UPD files ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38696/1/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/38696/1/src/vendorcode/amd/fsp/pica... PS1, Line 18:
I'm fine leaving the spaces for now. […]
Marshall showed me how this gets generated. The FSP build outputs it.
I synced this with the latest.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38696
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6428f618afc2a1cf1c35e93e00f905f90b2cd86a
Gerrit-Change-Number: 38696
Gerrit-PatchSet: 8
Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 22:26:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment