HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39816 )
Change subject: src: Include <smbios.h> when appropriate
......................................................................
Patch Set 6:
Patch Set 6:
Why did you drop the `chip.h` changes?
devicetree.cb needs indirect include of smbios.h in chip.h
Why???
Also, according to Jenkins that's not true:
Patch Set 1: Verified+1
done
thx
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12345a5b6c9ce94ca9f8b555154b2278a8ff97bf
Gerrit-Change-Number: 39816
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 Apr 2020 19:59:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment