Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43483 )
Change subject: Documentation/vendorcode/eltan/security.md: Fix bugs in the guide ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/43483/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43483/1//COMMIT_MSG@12 PS1, Line 12: during booting
*during boot* or *when booting*
Done
https://review.coreboot.org/c/coreboot/+/43483/1//COMMIT_MSG@14 PS1, Line 14: Fix the cbfstool extraction command to take account for stage file
… to take the stage file into account, which may …
Done
https://review.coreboot.org/c/coreboot/+/43483/1//COMMIT_MSG@17 PS1, Line 17: openssl
OpenSSL
Done
https://review.coreboot.org/c/coreboot/+/43483/1/Documentation/vendorcode/el... File Documentation/vendorcode/eltan/security.md:
https://review.coreboot.org/c/coreboot/+/43483/1/Documentation/vendorcode/el... PS1, Line 83: Note the
Note, the …
Done
https://review.coreboot.org/c/coreboot/+/43483/1/Documentation/vendorcode/el... PS1, Line 83: Note the `-m x86 -U` flags are required for correct extraction of stages. Certain stages are
Add a blank line above?
Done
https://review.coreboot.org/c/coreboot/+/43483/1/Documentation/vendorcode/el... PS1, Line 89: <
Is this needed?
Yes, it is needed to direct the hash file to stdin. I have changed the order to improve the readability.