13 Sep
2020
13 Sep
'20
10:18 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45174 )
Change subject: nb/intel/ironlake/raminit: Fix compiler bug ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
It looks good enough until somebody wants to fix the whole code. Can we get the commit message polished to merge this? I have a bad feeling to keep master broken all the time :-/
https://review.coreboot.org/c/coreboot/+/45174/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45174/1//COMMIT_MSG@7 PS1, Line 7: nb/intel/ironlake/raminit: Fix compiler bug I would say "Work around" not fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63cffc8812bd22695c01bf57283ca593b12e3d87
Gerrit-Change-Number: 45174
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 13 Sep 2020 20:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment