Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
Patch Set 7:
(4 comments)
It seems we don't have format-string warnings enabled?
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/apic.c File util/inteltool/apic.c:
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/apic.c@24 PS6, Line 24: #define IO_APIC_ADDR 0xfec00000
According to doc#332691-003EN (at 23.2.2) and Intel MP Spec. v1.4 (at 3.1) this is a fixed address.
Let's say: If there is a single I/O APIC, you can expect it there. And so far, FWIW, if there are multiple, the first uses this address, too.
https://review.coreboot.org/c/coreboot/+/35189/7/util/inteltool/apic.c File util/inteltool/apic.c:
https://review.coreboot.org/c/coreboot/+/35189/7/util/inteltool/apic.c@110 PS7, Line 110: lx This won't work on x86_32.
https://review.coreboot.org/c/coreboot/+/35189/7/util/inteltool/apic.c@110 PS7, Line 110: ld `i` is not a long, it's size_t?
https://review.coreboot.org/c/coreboot/+/35189/7/util/inteltool/apic.c@111 PS7, Line 111: (uint16_t) Why the cast?