Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38986 )
Change subject: WIP: xeonsp: Add common IIO-related code
......................................................................
Patch Set 10: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/38986/10/src/cpu/intel/xeonsp/iio.c
File src/cpu/intel/xeonsp/iio.c:
https://review.coreboot.org/c/coreboot/+/38986/10/src/cpu/intel/xeonsp/iio.c...
PS10, Line 24: static void assign_bridge_resources(struct iiostack_resource *stack_list,
nit: maybe add a blank line between these two declarations
https://review.coreboot.org/c/coreboot/+/38986/10/src/cpu/intel/xeonsp/iio.c...
PS10, Line 430: bux
bus
https://review.coreboot.org/c/coreboot/+/38986/10/src/cpu/intel/xeonsp/iio.c...
PS10, Line 451: die("%s: out of memory.\n", __func__);
lol, that would be hilarious
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38986
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c459fc5deb885c5f979499b75dc95633bb6c00f
Gerrit-Change-Number: 38986
Gerrit-PatchSet: 10
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Feb 2020 16:02:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment