build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36136 )
Change subject: soc/intel: skl,cnl,icl: rely on TOLUM as cbmem_top returned by FSP
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36136/14/src/drivers/intel/fsp2_0/h...
File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/36136/14/src/drivers/intel/fsp2_0/h...
PS14, Line 194: if (fsp_find_range_hob(re, fsp_reserved_memory_guid));
trailing semicolon indicates no statements, indent implies otherwise
https://review.coreboot.org/c/coreboot/+/36136/14/src/drivers/intel/fsp2_0/h...
PS14, Line 194: if (fsp_find_range_hob(re, fsp_reserved_memory_guid));
trailing statements should be on next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If66a00d1320917bc68afb32c19db0e24c6732812
Gerrit-Change-Number: 36136
Gerrit-PatchSet: 14
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Oct 2019 22:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment