[coreboot-gerrit] Change in coreboot[master]: hatch: automate creating a new variant in coreboot

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )

Change subject: hatch: automate creating a new variant in coreboot
......................................................................

Patch Set 17: Code-Review+1

(1 comment)

Looks okay to me. I will wait to see if other reviewers have any comments. Else +2 it tomorrow.

https://review.coreboot.org/c/coreboot/+/35239/17/util/mainboard/google/hatc... 
File util/mainboard/google/hatch/create_coreboot_variant.sh:

https://review.coreboot.org/c/coreboot/+/35239/17/util/mainboard/google/hatc... 
PS17, Line 40: echo "The baseboard directory for ${base} does not exist."
Kind of contradictory. Line 25 says this script is only for Hatch and here it checks to ensure that the baseboard directory exists. Is it just a check in place that will ensure it can be adapted to other baseboards in the future?