Looks okay to me. I will wait to see if other reviewers have any comments. Else +2 it tomorrow.

Patch set 17:Code-Review +1

View Change

1 comment:

• File util/mainboard/google/hatch/create_coreboot_variant.sh:

  • Patch Set #17, Line 40: echo "The baseboard directory for ${base} does not exist."

    Kind of contradictory. Line 25 says this script is only for Hatch and here it checks to ensure that the baseboard directory exists. Is it just a check in place that will ensure it can be adapted to other baseboards in the future?

To view, visit change 35239. To unsubscribe, or for help writing mail filters, visit settings.