Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46056 )
Change subject: acpi/device: Add GPIO binding property for an array of GPIOs ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46056/2/src/acpi/device.c File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/46056/2/src/acpi/device.c@1035 PS2, Line 1035:
nit: Probably we should add a comment here indicating what this actually generates? […]
Done
https://review.coreboot.org/c/coreboot/+/46056/2/src/acpi/device.c@1038 PS2, Line 1038: acpi_dp_add_reference(gpio, NULL, params->ref);
Do we want to support the case where params->ref is NULL and so we will have to just write a 0 for t […]
Done