John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36860 )
Change subject: mb/google/drallion/variants/drallion: Update thermal configuration for DPTF ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... PS1, Line 17: 127
please share the details on how these new high values are helping compared to previous old values? D […]
From b/144464314#8 We don't use critical policy to protect system overheat, we use thermal sensor PSV point and Tcc function to protect system overheat.
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... PS1, Line 60: 15
What's the reason for changing this from 21W to 15W for PL1 Maximum value ? What's the TDP of this d […]
Our project TDP is 15W, the reason is DPTF just use passive policy 1, so we set PL1 Max=TDP, and we run performance test by Aquarium 1000 fishes also can meet target 44+ FPS
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... PS1, Line 62: 10
Does these new lower (10000) values of TimeWindowMinimum/Maximum helping you to address any existing […]
There is no issue about this change, BTW is there any setting you recommendation about this value?
https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... PS1, Line 67: 4
please provide detailed reasons for changing this to such a lower value ? Did you check any performa […]
Which one do you confused? PL1 min or PL2 min? there will have a change that we will revise PL2 min from 4000 to 15000.