Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48597 )
Change subject: trace: Use dynamic address bytes everywhere we should. ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/em100/+/48597/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/em100/+/48597/1//COMMIT_MSG@7 PS1, Line 7: we should. nit: Drop this part?
https://review.coreboot.org/c/em100/+/48597/1/trace.c File trace.c:
https://review.coreboot.org/c/em100/+/48597/1/trace.c@235 PS1, Line 235: /* Special commands */ : switch (spi_command) { : case 0xb7: : address_mode = 4; : break; : case 0xe9: : address_mode = 3; : break; : } Huh, this is indented with spaces