Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47116 )
Change subject: soc/intel/skylake: Enable PCH thermal depending on devicetree
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47116/2/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/47116/2/src/soc/intel/skylake/chip....
PS2, Line 285: params->PchThermalDeviceEnable = dev && dev->enabled;
Yes, but all boards are presently declaring this device.
intel/kblrvp/variants/rvp11/overridetree.cb : off -> dev is currently on - will be off
kontron/bsl6/devicetree.cb : not defined -> dev is currently on - will be off
intel/saddlebrook/devicetree.cb : off -> dev is currently on - will be off
protectli/vault_kbl/devicetree.cb : off -> dev is currently on - will be off
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84bac2cec079370370ecf1e5e4742e6704921d40
Gerrit-Change-Number: 47116
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Nov 2020 20:54:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment