Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43663 )
Change subject: mb/google/zork/vilboz: enable LTE function
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v...
PS1, Line 5: #include <boardid.h>
Is this required?
Dear Furquan, I think may need to keep this, since some SKUs have LTE module, we need a logistic to control it. I need confirm with our PM. In addition, I think we need to add LTE module information into boxster. Right? Many thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43663
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e
Gerrit-Change-Number: 43663
Gerrit-PatchSet: 1
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 21 Jul 2020 05:05:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment