Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32850 )
Change subject: soc/intel/skylake: Add PCI Id for Kabylake DT
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/32850/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32850/1//COMMIT_MSG@7
PS1, Line 7: Added
use imperative mood in the subject line
Done
https://review.coreboot.org/#/c/32850/1//COMMIT_MSG@7
PS1, Line 7: src/include/device/pci_ids.h: Added another Kabylake DT
: src/soc/intelcommon/block/systemagent/systemagent.c: Added another KabyLake DT
a too long subject line
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I496b3a91f765d4fa137c32c9ee1e244803fc25d8
Gerrit-Change-Number: 32850
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Comment-Date: Tue, 21 May 2019 19:35:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-MessageType: comment