Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28565 )
Change subject: util/board_status: Add support of CMOS values dump ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patch Set 2: It doesn't hurt in the report... but this script is too powerful already for my taste (and should have had a clean redesign years ago, imho).
It should, yes. But that's outside the scope of this change ;-)
https://review.coreboot.org/c/coreboot/+/28565/2/util/board_status/board_sta... File util/board_status/board_status.sh:
https://review.coreboot.org/c/coreboot/+/28565/2/util/board_status/board_sta... PS2, Line 387: if [ -n "$NVRAMTOOL_PATH" ]; then instead of this extensive test, why not just initialize nvramtool_cmd to "nvramtool" and override that in the -n handler?