Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37344 )
Change subject: Add support for older EM100Pro
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/em100/+/37344/1/em100.c
File em100.c:
https://review.coreboot.org/c/em100/+/37344/1/em100.c@260
PS1, Line 260: 0xff
Why this magic number? Isn't it `HWVERSION_EM100PRO_EARLY`?
Done
https://review.coreboot.org/c/em100/+/37344/1/em100.c@502
PS1, Line 502: 0xff
Same
Done
https://review.coreboot.org/c/em100/+/37344/1/em100.c@930
PS1, Line 930:
Trailing space
Done
https://review.coreboot.org/c/em100/+/37344/1/em100.c@931
PS1, Line 931: 0xff
Another
Done
--
To view, visit
https://review.coreboot.org/c/em100/+/37344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I18f19d83b515c4e740f1efec07d49c1ceb2373ec
Gerrit-Change-Number: 37344
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 01 Dec 2019 01:10:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment