Attention is currently required from: Cliff Huang, Krystian Hebel, Lance Zhao, Paul Menzel, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82698?usp=email )
Change subject: acpi/acpi.c: fix XSDT handling on QEMU
......................................................................
Patch Set 2:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/82698/comment/cccff3b0_766a8de2?usp... :
PS2, Line 1491: if (rsdp->xsdt_address == 0) {
: xsdt = (acpi_xsdt_t *)current;
I think it's better to be explicitly look whether xsdt was added on first boot behind the current pointer?
if (!rsdp->xsdt_address && rsdp->xsdt_address + sizeof(acpi_xsdt_t) => current) {
current = rsdp->xsdt_address + sizeof(acpi_xsdt_t);
current = acpi_align_current(current);
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82698?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f38467b7de3f35fc3ec3854a840de8345cd0fe5
Gerrit-Change-Number: 82698
Gerrit-PatchSet: 2
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 13 Jun 2024 09:36:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No