Attention is currently required from: Arthur Heymans, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58700 )
Change subject: cpu/x86/smm: Support PARALLEL_MP with SMM_ASEG
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/58700/comment/1a19a7a5_c3a5340d
PS2, Line 603: * +-----------------+ <- smram + size == 0x10000
0xb0000 ?
Ack
https://review.coreboot.org/c/coreboot/+/58700/comment/a52c7833_8e876d65
PS2, Line 613: * | stub code | <- cpu3, etc
Is MAX_CPUS=4 correct, remove ", etc"
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If499e21a8dc7fca18bd5990f833170d0fc21e10c
Gerrit-Change-Number: 58700
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 03 Feb 2022 09:12:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment