Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46509 )
Change subject: mrc_cache: Add config MRC_SAVE_HASH_IN_TPM ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46509/4/src/drivers/intel/fsp2_0/me... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/46509/4/src/drivers/intel/fsp2_0/me... PS4, Line 30: _Static_assert(!CONFIG(MRC_SAVE_HASH_IN_TPM) || This shouldn't remain in this file now though, because it's not specific to FSP 2.0. If you want to keep it, it should be moved to one of the MRC cache files.
https://review.coreboot.org/c/coreboot/+/46509/4/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/4/src/drivers/mrc_cache/Kconf... PS4, Line 55: default y if CHROMEOS Yes, please let's remove the CHROMEOS. Feel free to send out a PSA on the mailing list (although generally we make changes to vboot all the time, I'm not sure if this is a particularly big deal).