Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36823/4/src/soc/amd/stoneyridge/Mak... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36823/4/src/soc/amd/stoneyridge/Mak... PS4, Line 140: ifeq ($(CONFIG_SOC_AMD_MERLINFALCON),y) : : ifeq ($(CONFIG_HAVE_MERLINFALCON_BINARIES),y) : FIRMWARE_TYPE=CZ : else : FIRMWARE_TYPE=ST : endif Don't you still have the same problem you're trying to avoid? That is, when you select Merlin Falcon when you don't have the right binaries, don't you silently still get ST?