Attention is currently required from: zanxi chen, Bob Moragues, Julius Werner, Xuxin Xiong.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57329 )
Change subject: mb/google/trogdor: Add LCM_ID to SKU_ID
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/trogdor/boardid.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127577):
https://review.coreboot.org/c/coreboot/+/57329/comment/fb2e6569_6a4ecebf
PS5, Line 49: const gpio_t pins[] = {[1] = GPIO(11),[0] = GPIO(4)};
space required after that ',' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I018b3f460f9d084d1a3f0dac026f1cd9dde284e2
Gerrit-Change-Number: 57329
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: Wenli Xu
xuwenli@huaqin.corp-partner.google.com
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Comment-Date: Tue, 07 Sep 2021 07:26:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment