Attention is currently required from: Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70797 )
Change subject: cpu/x86/mtrr: use lapicid instead of cpu_index calls
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/70797/comment/a815833e_a126ec9f
PS1, Line 295: unsigned int cpu_idx = lapicid();
nit: I know this was asked for in the original patch, but it is only used one more time in this function - does it really need to be a variable here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d226704051ab171891775a618ce7897b74fde16
Gerrit-Change-Number: 70797
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 14 Dec 2022 23:24:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment