Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32297 )
Change subject: soc/intel/cannonlake: Enable PlatformDebugConsent by Kconfig ......................................................................
Patch Set 5: Code-Review+2
(4 comments)
https://review.coreboot.org/#/c/32297/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32297/4//COMMIT_MSG@10 PS4, Line 10: y
done. […]
Ack
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/Kconfig@293 PS2, Line 293: bool "Support USB DBC for Cannonlake"
Please explain in a help text what this is and how to use it.
Done
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/romstage/fs... PS2, Line 119: m_cfg->PlatformDebugConsent = config->DebugConsent;
If we need to get rid of the devicetree option, USE_DBC_CANNONLAKE will have to instead be a choice […]
Done
https://review.coreboot.org/#/c/32297/4/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32297/4/src/soc/intel/cannonlake/romstage/fs... PS4, Line 115:
done […]
Ack